Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 400042: Remove MySQL support of constraint (has it skips it silently) and use double instead of float (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by ced
Modified:
16 years, 1 month ago
Reviewers:
bch, yangoon1
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Re-enable add/drop constraint because UNIQUE works on MySQL but keep Tryton validation for CHECK #

Patch Set 3 : Better README comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M README View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/backend/mysql/database.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/backend/mysql/fields.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/backend/mysql/table.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
ced
16 years, 1 month ago (2010-03-10 15:40:46 UTC) #1
yangoon1
sorry, inline comments atm not working for me: * MySQL doesn't support constraint but Tryton ...
16 years, 1 month ago (2010-03-10 17:51:33 UTC) #2
ced
On 2010/03/10 17:51:33, yangoon wrote: > sorry, inline comments atm not working for me: > ...
16 years, 1 month ago (2010-03-10 18:09:56 UTC) #3
ced
16 years, 1 month ago (2010-03-11 10:51:36 UTC) #4
ced
16 years, 1 month ago (2010-03-11 10:53:04 UTC) #5
bch
On 2010/03/11 10:53:04, ced wrote: > OK for me
16 years, 1 month ago (2010-03-11 10:55:06 UTC) #6
ced
On 2010/03/11 10:55:06, bch wrote: > On 2010/03/11 10:53:04, ced wrote: > > > > ...
16 years, 1 month ago (2010-03-11 11:06:13 UTC) #7
yangoon1
I wouldn't remove the comment, if this is a drawback for the use of Tryton ...
16 years, 1 month ago (2010-03-11 11:19:19 UTC) #8
ced
16 years, 1 month ago (2010-03-11 11:23:29 UTC) #9
On 2010/03/11 11:19:19, yangoon wrote:
> I wouldn't remove the comment, if this is a drawback for the use of Tryton
with
> mysql.

There is a lot of drawback like this one in Tryton for any database backend and
other stuffs.
We will not document what is missing in each tools. Only the things that we can
not workaround.

> 
> MySQL doesn't support multi-transactional UNIQUE constraint.
> 
> Better?

MySQL supports multi-transactional UNIQUE constraint. It is CHECK constraint
that is not supported and this doesn't require multi-transactional behavior.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b