Use GADGET context by default fro bad RenderingContext value

[johnfargo, 2011-01-27 22:48:03]

LGTM++

On Thu, Jan 27, 2011 at 1:39 PM, <zhoresh@gmail.com> wrote:

> Reviewers: dev-remailer_shindig.apache.org, johnfargo,
>
>
>
> Please review this at http://codereview.appspot.com/3982052/
>
> Affected files:
>
>  java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
>
>
> ### Eclipse Workspace Patch 1.0
> #P shindig-project
> Index:
> java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
> ===================================================================
> ---
> java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
> (revision 1064259)
> +++
> java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java
> (working copy)
> @@ -62,16 +62,17 @@
>   }
>
>   public static RenderingContext valueOfParam(String param) {
> -    // Exception: when no &c= parameter provided, default to GADGET.
> -    if (param == null) {
> -      return RenderingContext.GADGET;
> -    }
> -    for (RenderingContext rc : RenderingContext.values()) {
> -      String rcParam = rc.getParamValue();
> -      if (rcParam != null && rcParam.equals(param)) {
> -        return rc;
> +    // Exception: when no &c= parameter provided or bad, default to
> GADGET.
> +    RenderingContext c = RenderingContext.GADGET;
> +    if (param != null) {
> +      for (RenderingContext rc : RenderingContext.values()) {
> +        String rcParam = rc.getParamValue();
> +        if (rcParam != null && rcParam.equals(param)) {
> +          c = rc;
> +          break;
> +        }
>       }
>     }
> -    return null;
> +    return c;
>   }
>  }
>
>
>