Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(398)

Issue 39820045: energy module now is accessible with Config path

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by orazio.briante
Modified:
4 years, 9 months ago
Reviewers:
Tommaso Pecorella
CC:
ns-3-reviews_googlegroups.com, ns-3-reviews_googlegroups.
Visibility:
Public.

Description

energy module now is accessible with Config path

Patch Set 1 #

Total comments: 4

Patch Set 2 : energy module now is accessible with Config path #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -21 lines) Patch
M examples/energy/energy-model-example.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M src/energy/helper/energy-source-container.cc View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/energy/helper/wifi-radio-energy-model-helper.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M src/energy/model/device-energy-model.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/energy/model/device-energy-model-container.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M src/energy/model/device-energy-model-container.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/energy/model/energy-source.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/energy/model/energy-source.cc View 1 11 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Tommaso Pecorella
Hi, beside the comments, can you provide a rationale of the changes ? I know ...
4 years, 9 months ago (2014-01-11 18:47:22 UTC) #1
orazio.briante
I fixed files. I use std::vector<Ptr<DeviceEnergyModel> > instead of DeviceEnergyModelContainer because the last one have ...
4 years, 9 months ago (2014-01-11 20:42:05 UTC) #2
Tommaso Pecorella
I see… this makes me wonder why we d have a DeviceEnergyModelContainer as a class ...
4 years, 9 months ago (2014-01-11 21:39:59 UTC) #3
orazio.briante
4 years, 9 months ago (2014-01-12 09:50:32 UTC) #4
I know what you mean... but this module is used in other modules and i don't
want make radical changes...

Best Regards.

On 2014/01/11 21:39:59, Tommaso Pecorella wrote:
> I see… this makes me wonder why we d have a DeviceEnergyModelContainer as a
> class and not as a typedef.
> 
> The very same functionality could have been done with a simple:
>   typedef std::vector< Ptr<DeviceEnergyModel> > DeviceEnergyModelContainer;
> well, more or less.
> 
> Sadly, removing DeviceEnergyModelContainer could be a major issue.
> 
> Said so, I have no more comments.
> 
>
https://codereview.appspot.com/39820045/diff/20001/src/energy/helper/energy-s...
> File src/energy/helper/energy-source-container.cc (right):
> 
>
https://codereview.appspot.com/39820045/diff/20001/src/energy/helper/energy-s...
> src/energy/helper/energy-source-container.cc:37: .AddAttribute ("List", "The
> EnergySources associated to the node",
> Change this attribute name to something more explicative (sorry, I forgot in
the
> first revision).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b