Display deleted lines in One2Many and Many2Many

[ced, 2011-01-27 17:35:40]

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/mode...
File tryton/gui/window/view_form/model/group.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/group.py:32: self.__deleted, self.__removed =
{}, {}
Is the list fields still needed?

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/many2many.py:100: if name !=
'readonly':
Perhaps a comment could be good here.

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
File tryton/gui/window/view_form/view/form_gtk/one2many.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/one2many.py:220: if name !=
'readonly':
Idem for many2many

[ced, 2011-01-27 18:03:56]

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
File tryton/gui/window/view_form/view/form_gtk/one2many.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/one2many.py:205: return False
Add a shortcut for undelete.

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/one2many.py:357: if signal_data[4]:
This will not work with many selected lines.
I think you must add a listener on the selection of the list and show or not the
buttons if there is at least one record that can need it.

[nicoe, 2011-01-28 12:34:24]

Most of the issues are done in the next upload

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/mode...
File tryton/gui/window/view_form/model/group.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/mode...
tryton/gui/window/view_form/model/group.py:32: self.__deleted, self.__removed =
{}, {}
On 2011/01/27 17:35:40, ced wrote:
> Is the list fields still needed?

Done.

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
File tryton/gui/window/view_form/view/form_gtk/many2many.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/many2many.py:100: if name !=
'readonly':
On 2011/01/27 17:35:40, ced wrote:
> Perhaps a comment could be good here.

Done.

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
File tryton/gui/window/view_form/view/form_gtk/one2many.py (right):

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/one2many.py:205: return False
On 2011/01/27 18:03:56, ced wrote:
> Add a shortcut for undelete.

Done.

http://codereview.appspot.com/3977047/diff/1/tryton/gui/window/view_form/view...
tryton/gui/window/view_form/view/form_gtk/one2many.py:220: if name !=
'readonly':
On 2011/01/27 17:35:40, ced wrote:
> Idem for many2many

Done.

[bch, 2011-01-28 16:40:03]

Nice feature :)

I made a quick test and it seems that I cannot add a new line (I'm on adresses
of party):
The window with the address form open correctly when I clic on new, but when I
click 'validate' and then 'close' the new address disapear form the O2M.

[ced, 2011-02-07 19:31:33]

http://codereview.appspot.com/3977047/diff/29001/tryton/gui/window/view_form/...
File tryton/gui/window/view_form/model/field.py (right):

http://codereview.appspot.com/3977047/diff/29001/tryton/gui/window/view_form/...
tryton/gui/window/view_form/model/field.py:179: if record.group.readonly or
record.readonly:
Is the record.readonly case should not be stored in state_attrs?
What do it happen when record.readonly is set back to False?

[nicoe, 2011-02-08 11:42:59]

http://codereview.appspot.com/3977047/diff/29001/tryton/gui/window/view_form/...
File tryton/gui/window/view_form/model/field.py (right):

http://codereview.appspot.com/3977047/diff/29001/tryton/gui/window/view_form/...
tryton/gui/window/view_form/model/field.py:179: if record.group.readonly or
record.readonly:
On 2011/02/07 19:31:36, ced wrote:
> Is the record.readonly case should not be stored in state_attrs?
> What do it happen when record.readonly is set back to False?

Done.

[ced, 2011-02-11 14:12:34]

You must update the help page with the new shortcut.

http://codereview.appspot.com/3977047/diff/43001/tryton/gui/window/view_form/...
File tryton/gui/window/view_form/screen/screen.py (right):

http://codereview.appspot.com/3977047/diff/43001/tryton/gui/window/view_form/...
tryton/gui/window/view_form/screen/screen.py:231: (record.deleted or
record.removed) if record else False))
No more used

[nicoe, 2011-02-15 14:49:18]

http://codereview.appspot.com/3977047/diff/43001/tryton/gui/window/view_form/...
File tryton/gui/window/view_form/screen/screen.py (right):

http://codereview.appspot.com/3977047/diff/43001/tryton/gui/window/view_form/...
tryton/gui/window/view_form/screen/screen.py:231: (record.deleted or
record.removed) if record else False))
On 2011/02/11 14:12:34, ced wrote:
> No more used

Done.

[ced, 2011-02-16 14:25:32]

LGTM