code review 3973054: crypto/openpgp/packet: add public key support

crypto/openpgp/packet: add public key support

Note that DSA public key support is nascent and the verification
functions clearly don't support it yet. I'm intending to get RSA keys
working first.

[agl1, 2011-02-03 14:41:09]

Hello bradfitzgo (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-02-03 14:58:20]

LGTM

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/public_key.go (right):

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:5: package packet
package-level docs?

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:23: PublicKey    interface{} //
Either a *rsa.PublicKey or *dsa.PublicKey
always cry a little when I see stuff like this but I don't have a better answer.

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:24: Fingerprint  []byte
worth documenting how large?

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:25: KeyId        uint64
this is the thing that gpg --list-{,secret-}keys shows as 32-bit hex?

when I added keyids to KeyIdString() to your packet.go in camlistore
(bfcc2ae8f5b15c25b9e7c690f6dbab760c4b1091) I thought we'd discussed that RFC
4880 had a documentation error about the length of this?

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:183: return
error.UnsupportedError("non-RSA public key")
TODO for DSA?  (it's already in your commit message, but those are harder to see
later)

[agl1, 2011-02-04 14:00:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=b5d17ce5197c ***

crypto/openpgp/packet: add public key support

Note that DSA public key support is nascent and the verification
functions clearly don't support it yet. I'm intending to get RSA keys
working first.

R=bradfitzgo
CC=golang-dev
http://codereview.appspot.com/3973054

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
File src/pkg/crypto/openpgp/packet/public_key.go (right):

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:5: package packet
On 2011/02/03 14:58:21, bradfitzgo wrote:
> package-level docs?

package-level docs are in packet.go

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:23: PublicKey    interface{} //
Either a *rsa.PublicKey or *dsa.PublicKey
On 2011/02/03 14:58:21, bradfitzgo wrote:
> always cry a little when I see stuff like this but I don't have a better
answer.

Union types! However, I can't both enjoy Go's simplicity and request new stuff
at the same time.

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:24: Fingerprint  []byte
On 2011/02/03 14:58:21, bradfitzgo wrote:
> worth documenting how large?

Done.

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:25: KeyId        uint64
On 2011/02/03 14:58:21, bradfitzgo wrote:
> this is the thing that gpg --list-{,secret-}keys shows as 32-bit hex?

Yes.

> when I added keyids to KeyIdString() to your packet.go in camlistore
> (bfcc2ae8f5b15c25b9e7c690f6dbab760c4b1091) I thought we'd discussed that RFC
> 4880 had a documentation error about the length of this?

I was wrong. KeyIds are printed out as 32-bit numbers by PGP/GPG and so on.
However, they are used to match up keys in the protocol itself and really are
64-bit.

http://codereview.appspot.com/3973054/diff/4001/src/pkg/crypto/openpgp/packet...
src/pkg/crypto/openpgp/packet/public_key.go:183: return
error.UnsupportedError("non-RSA public key")
On 2011/02/03 14:58:21, bradfitzgo wrote:
> TODO for DSA?  (it's already in your commit message, but those are harder to
see
> later)

Done.

[rsc, 2011-02-04 18:40:04]

That was cool!

I didn't know if you left draft comments in Rietveld,
it would attach them to the mail that hg submit sends.

Russ

[agl1, 2011-02-04 18:47:18]

On Fri, Feb 4, 2011 at 1:40 PM, Russ Cox <rsc@golang.org> wrote:
> I didn't know if you left draft comments in Rietveld,
> it would attach them to the mail that hg submit sends.

Nor did I!


AGL