Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)

Issue 3972045: Issue �3080: Fix import machinery for non-ASCII module names and unencodable paths

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by haypo_gmail
Modified:
8 years, 12 months ago
Reviewers:
sasha
Visibility:
Public.

Patch Set 1 #

Total comments: 32
Unified diffs Side-by-side diffs Delta from patch set Stats (+1570 lines, -1098 lines) Patch
M Doc/c-api/module.rst View 3 chunks +17 lines, -7 lines 0 comments Download
M Include/import.h View 3 chunks +56 lines, -17 lines 1 comment Download
M Include/moduleobject.h View 1 chunk +2 lines, -0 lines 1 comment Download
M Include/pycapsule.h View 1 chunk +3 lines, -1 line 1 comment Download
M Lib/test/test_pydoc.py View 1 chunk +1 line, -1 line 0 comments Download
M Lib/unittest/test/test_loader.py View 2 chunks +2 lines, -2 lines 0 comments Download
M Modules/zipimport.c View 27 chunks +160 lines, -126 lines 4 comments Download
M Objects/moduleobject.c View 3 chunks +42 lines, -18 lines 0 comments Download
M PC/import_nt.c View 1 chunk +43 lines, -41 lines 0 comments Download
M Python/dynload_aix.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/dynload_dl.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/dynload_hpux.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/dynload_next.c View 1 chunk +2 lines, -2 lines 0 comments Download
M Python/dynload_os2.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/dynload_shlib.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/dynload_win.c View 1 chunk +1 line, -1 line 0 comments Download
M Python/import.c View 101 chunks +1159 lines, -845 lines 25 comments Download
M Python/importdl.h View 1 chunk +1 line, -1 line 0 comments Download
M Python/importdl.c View 3 chunks +46 lines, -31 lines 0 comments Download
A issue3080.py View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 7
haypo_gmail
http://codereview.appspot.com/3972045/diff/1/Python/import.c File Python/import.c (right): http://codereview.appspot.com/3972045/diff/1/Python/import.c#newcode3556 Python/import.c:3556: if (!PyArg_ParseTuple(args, "s:init_builtin", &name)) Oops, test_importlib crashs because of ...
9 years, 1 month ago (2011-01-21 02:06:36 UTC) #1
sasha
Some initial comments. http://codereview.appspot.com/3972045/diff/1/Python/import.c File Python/import.c (right): http://codereview.appspot.com/3972045/diff/1/Python/import.c#newcode122 Python/import.c:122: 'c', 'p', 'y', 't', 'h', 'o', ...
9 years, 1 month ago (2011-01-21 02:19:14 UTC) #2
haypo_gmail
http://codereview.appspot.com/3972045/diff/1/Python/import.c File Python/import.c (right): http://codereview.appspot.com/3972045/diff/1/Python/import.c#newcode122 Python/import.c:122: 'c', 'p', 'y', 't', 'h', 'o', 'n', '-', '3', ...
9 years, 1 month ago (2011-01-21 17:23:59 UTC) #3
sasha
http://codereview.appspot.com/3972045/diff/1/Python/import.c File Python/import.c (right): http://codereview.appspot.com/3972045/diff/1/Python/import.c#newcode122 Python/import.c:122: 'c', 'p', 'y', 't', 'h', 'o', 'n', '-', '3', ...
9 years, 1 month ago (2011-01-21 18:21:04 UTC) #4
sasha
http://codereview.appspot.com/3972045/diff/1/Include/import.h File Include/import.h (right): http://codereview.appspot.com/3972045/diff/1/Include/import.h#newcode13 Include/import.h:13: char *name, /* UTF-8 encoded string */ Thanks for ...
9 years, 1 month ago (2011-01-21 18:25:57 UTC) #5
sasha
http://codereview.appspot.com/3972045/diff/1/Include/moduleobject.h File Include/moduleobject.h (right): http://codereview.appspot.com/3972045/diff/1/Include/moduleobject.h#newcode16 Include/moduleobject.h:16: PyAPI_FUNC(PyObject *) PyModule_NewUnicode(PyObject *name); "Unicode" suffix leaves it ambiguous ...
9 years, 1 month ago (2011-01-21 19:27:48 UTC) #6
haypo_gmail
8 years, 12 months ago (2011-02-22 23:52:37 UTC) #7
On 2011/01/21 18:25:57, sasha wrote:
> http://codereview.appspot.com/3972045/diff/1/Include/import.h
> File Include/import.h (right):
> 
> http://codereview.appspot.com/3972045/diff/1/Include/import.h#newcode13
> Include/import.h:13: char *name,                 /* UTF-8 encoded string */
> Thanks for documenting char* arguments like this.  I wonder if we can convince
> Georg that these are documentation changes and should go in RC2?

I just commited this commit: r88517 (3.3), r88518 (3.2). So it will be in 3.2.1.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b