Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(246)

Issue 3950041: Add communication between boards (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by ced
Modified:
15 years ago
Reviewers:
bch, yangoon, nicoe, udono
Visibility:
Public.

Description

The communication (refresh) is simply activated by using "_active_%s" in the domain of the act_window (where %s is the id of the other act_window). When the selection of one board is changed, every other board domain are evaluated and if they change the corresponding board is reloaded.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -9 lines) Patch
M CHANGELOG View 1 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_board/action.py View 1 5 chunks +34 lines, -5 lines 0 comments Download
M tryton/gui/window/view_board/view_board.py View 3 chunks +13 lines, -1 line 0 comments Download
M tryton/gui/window/view_tree/view_tree.py View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7
ced
15 years, 1 month ago (2011-01-10 16:38:31 UTC) #1
yangoon
15 years, 1 month ago (2011-01-10 18:05:25 UTC) #2
udono
15 years, 1 month ago (2011-01-10 19:07:38 UTC) #3
udono
I patched the client and opened the dashboard. But how can I test the new ...
15 years, 1 month ago (2011-01-13 15:08:34 UTC) #4
ced
On 2011/01/13 15:08:34, udono wrote: > I patched the client and opened the dashboard. But ...
15 years, 1 month ago (2011-01-13 15:19:10 UTC) #5
nicoe
http://codereview.appspot.com/3950041/diff/1/tryton/gui/window/view_board/action.py File tryton/gui/window/view_board/action.py (right): http://codereview.appspot.com/3950041/diff/1/tryton/gui/window/view_board/action.py#newcode267 tryton/gui/window/view_board/action.py:267: return {'id': self.tree.sel_id_get()} Are you sure that you always ...
15 years, 1 month ago (2011-01-13 15:54:24 UTC) #6
ced
15 years, 1 month ago (2011-01-13 16:00:22 UTC) #7
http://codereview.appspot.com/3950041/diff/1/tryton/gui/window/view_board/act...
File tryton/gui/window/view_board/action.py (right):

http://codereview.appspot.com/3950041/diff/1/tryton/gui/window/view_board/act...
tryton/gui/window/view_board/action.py:267: return {'id':
self.tree.sel_id_get()}
On 2011/01/13 15:54:24, nicoe wrote:
> Are you sure that you always have either self.screen or self.tree when
accessing
> the active property ?

No but it is not a problem because in this case the value of active will be None
and the PYSONDecoder will manage the exception with the default value.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b