Issue 39420047: issue402

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 39420047: issue402

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by Silvan S

Modified:
11 years, 3 months ago

Reviewers:
malte.helmert

Visibility:
Public.

More Reviews

Patch Set 2 : fixed comments #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	src/search/pdbs/pattern_generation_haslum.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
	M	src/search/pdbs/pattern_generation_haslum.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

malte.helmert

https://codereview.appspot.com/39420047/diff/1/src/search/pdbs/pattern_generation_haslum.h File src/search/pdbs/pattern_generation_haslum.h (right): https://codereview.appspot.com/39420047/diff/1/src/search/pdbs/pattern_generation_haslum.h#newcode40 src/search/pdbs/pattern_generation_haslum.h:40: to avoid recomputing it for every sample, see issue402) ...

11 years, 3 months ago (2013-12-30 18:58:53 UTC) #2

Fixed your suggestions.

Expand All Messages | Collapse All Messages