Issue 39410044: NV: codereview

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 39410044: NV: codereview (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by NamanV

Modified:
11 years ago

Reviewers:
mail2coolgarg

Base URL:
https://immp123.unfuddle.com/svn/immp123_immp/immp/

Visibility:
Public.

More Reviews

Description

NV: codereview

Patch Set 1 #

Total comments: 6

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -18 lines)			Patch
M	app/controllers/slphome_controller.rb	View	1 chunk	+50 lines, -2 lines	2 comments	Download
M	app/models/slp_client.rb	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	app/models/slp_user.rb	View	1 chunk	+8 lines, -3 lines	1 comment	Download
M	app/views/layouts/_header.html.erb	View	1 chunk	+10 lines, -1 line	0 comments	Download
A	app/views/slphome/addClient.html.erb	View	1 chunk	+30 lines, -0 lines	1 comment	Download
A	app/views/slphome/addUser.html.erb	View	1 chunk	+48 lines, -0 lines	1 comment	Download
A	app/views/slphome/dashboard.html.erb	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	app/views/slphome/index.html.erb	View	1 chunk	+2 lines, -8 lines	1 comment	Download
M	app/views/slphome/test.html.erb	View	1 chunk	+1 line, -1 line	0 comments	Download
A	app/views/slphome/viewClient.html.erb	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	app/views/slphome/viewUser.html.erb	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	config/routes.rb	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	db/migrate/20131209055138_change_type_to_user_type_in_slp_user.rb	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	db/schema.rb	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mail2coolgarg

11 years, 9 months ago (2013-12-09 17:16:55 UTC) #1

good work :)
Fix the mentioned comments.

https://codereview.appspot.com/39410044/diff/1/app/controllers/slphome_contro...
File app/controllers/slphome_controller.rb (right):

https://codereview.appspot.com/39410044/diff/1/app/controllers/slphome_contro...
app/controllers/slphome_controller.rb:27: user = SlpUser.new
move new user code in SlpUser, as we might need this from API also.

https://codereview.appspot.com/39410044/diff/1/app/controllers/slphome_contro...
app/controllers/slphome_controller.rb:47: client = SlpClient.new
same.

https://codereview.appspot.com/39410044/diff/1/app/models/slp_user.rb
File app/models/slp_user.rb (right):

https://codereview.appspot.com/39410044/diff/1/app/models/slp_user.rb#newcode9
app/models/slp_user.rb:9: user = SlpUser.where("corpcode = '#{corpcode}'").first
change this logic to include mobile/email and password also.

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/addClient.ht...
File app/views/slphome/addClient.html.erb (right):

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/addClient.ht...
app/views/slphome/addClient.html.erb:7: <label>Mobile number: </label>
format this file.

<div>
  <p> ... </p>
   ......
</div>

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/addUser.html...
File app/views/slphome/addUser.html.erb (right):

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/addUser.html...
app/views/slphome/addUser.html.erb:28: <input type="text" name ="email" /> <br
/>
format it.

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/index.html.erb
File app/views/slphome/index.html.erb (right):

https://codereview.appspot.com/39410044/diff/1/app/views/slphome/index.html.e...
app/views/slphome/index.html.erb:6: Corp code: <input type="text"
name="corpcode"><br>

<span>Corp code: </span>

and same to other fields as well.

Expand All Messages | Collapse All Messages