Issue 3939043: Improve size of nested views

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3939043: Improve size of nested views (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ced

Modified:
15 years ago

Reviewers:
vincentvdl, yangoon, nicoe, udono

Visibility:
Public.

Patch Set 2 : Fix namespace pollution and clear the code #

Patch Set 3 : Better improvement by resetting size request for nested views #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
M	tryton/gui/window/view_form/view/form.py	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/many2many.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/one2many.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tryton/gui/window/view_form/view/list.py	View	1 2	1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

udono

Works for me. IMHO it looks a little bit better with the patch.

15 years, 1 month ago (2011-01-13 14:20:20 UTC) #3

nicoe

http://codereview.appspot.com/3939043/diff/1/tryton/gui/window/view_form/view/list.py File tryton/gui/window/view_form/view/list.py (right): http://codereview.appspot.com/3939043/diff/1/tryton/gui/window/view_form/view/list.py#newcode162 tryton/gui/window/view_form/view/list.py:162: self.viewport = gtk.Viewport() Polluting the namespace of self http://codereview.appspot.com/3939043/diff/1/tryton/gui/window/view_form/view/list.py#newcode171 ...

15 years, 1 month ago (2011-01-13 16:06:12 UTC) #4

Expand All Messages | Collapse All Messages