Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(555)

Issue 3935043: Add option to prevent database listing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by nicoe
Modified:
14 years, 11 months ago
Reviewers:
yangoon, ced, timitos
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M etc/trytond.conf View 1 chunk +3 lines, -0 lines 0 comments Download
M trytond/config.py View 1 chunk +1 line, -0 lines 0 comments Download
M trytond/protocols/dispatcher.py View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6
nicoe
15 years, 1 month ago (2011-01-12 08:45:52 UTC) #1
ced
LGTM
15 years, 1 month ago (2011-01-12 10:07:00 UTC) #2
yangoon
http://codereview.appspot.com/3935043/diff/1/trytond/protocols/dispatcher.py File trytond/protocols/dispatcher.py (right): http://codereview.appspot.com/3935043/diff/1/trytond/protocols/dispatcher.py#newcode72 trytond/protocols/dispatcher.py:72: raise Exception('AccessDenied') Should it really raise an exception? Or ...
15 years, 1 month ago (2011-01-12 13:04:18 UTC) #3
timitos
How will this patch interact with the connection manager? For the moment it seems that ...
15 years, 1 month ago (2011-01-13 07:39:07 UTC) #4
nicoe
http://codereview.appspot.com/3935043/diff/1/trytond/protocols/dispatcher.py File trytond/protocols/dispatcher.py (right): http://codereview.appspot.com/3935043/diff/1/trytond/protocols/dispatcher.py#newcode72 trytond/protocols/dispatcher.py:72: raise Exception('AccessDenied') On 2011/01/12 13:04:18, yangoon wrote: > Should ...
15 years, 1 month ago (2011-01-13 08:44:27 UTC) #5
nicoe
15 years, 1 month ago (2011-01-13 08:46:13 UTC) #6
On 2011/01/13 07:39:07, timitos wrote:
> How will this patch interact with the connection manager? For the moment it
> seems that i cannot create a connection for a server with this option set as
the
> connection manager only provides the db list but no field to enter a db name
> manually.

I am working on updating the connection manager patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b