code review 3926041: A base32 impl. from RFC4648. It is modeled after the

A base32 impl. from RFC4648. It is modeled after the
        encoding/base64 package

[Miek Gieben, 2011-01-19 20:26:33]

Hello golang-dev@googlegroups.com (cc: Miek Gieben,
golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2011-01-19 20:39:56]

Looks good to me.
Please make the few changes below and run hg mail again.
Also please complete a CLA as described at
http://golang.org/doc/contribute.html#copyright

Thanks.
Russ

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
File src/pkg/encoding/base32/base32.go (right):

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
src/pkg/encoding/base32/base32.go:19: // 32-character alphabet.  The most common
encoding is the "base64"
// 32-character alphabet.  The most common is the "base32" encoding
// introduced for SASL GSSAPI and standardized in RFC 4648.
// The alternate "base32hex" encoding is used in DNSSEC.

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
src/pkg/encoding/base32/base32.go:49: // HexEncoding is the alternate base32
encoding defined in RFC 4648.
// HexEncoding is the ``Extended Hex Alphabet'' defined in RFC 4648.
// It is typically used in DNS.

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
src/pkg/encoding/base32/base32.go:234: /* do the top bytes contain any data? */
use // comment

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
src/pkg/encoding/base32/base32.go:286: //n += dlen
delete

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
File src/pkg/encoding/base32/base32_test.go (right):

http://codereview.appspot.com/3926041/diff/2001/src/pkg/encoding/base32/base3...
src/pkg/encoding/base32/base32_test.go:19: // RFC 3548 examples
delete block

[rsc, 2011-01-19 20:41:46]

also please add encoding/base32 to src/pkg/Makefile and add it to the CL.
(hg file 3926041 src/pkg/Makefile; after editing)

[Miek Gieben, 2011-01-20 10:40:47]

Hello rsc (cc: Miek Gieben, golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-20 16:29:32]

LGTM

[rsc, 2011-01-20 17:51:17]

*** Submitted as 83b6d630b284 ***

encoding/base32: new package

R=rsc
CC=Miek Gieben, golang-dev
http://codereview.appspot.com/3926041

Committer: Russ Cox <rsc@golang.org>