Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(260)

Issue 39100045: Ensure variables are decoded to unicode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by M-A
Modified:
11 years, 7 months ago
Reviewers:
csharp
CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Base URL:
https://code.google.com/p/swarming.client@master
Visibility:
Public.

Description

Ensure variables are decoded to unicode. Add asserts to ensure variables are unicode. Otherwise it could get into a situation where variables are left as str and this would cause an assertion. R=csharp@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=client&r=9cc42c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M isolate.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
M-A
Failure looked like; '/b/build/slave/android/build/src/out/Debug' Traceback (most recent call last): File "/b/build/slave/android/build/src/tools/swarming_client/isolate.py", line 2181, in main ...
11 years, 7 months ago (2013-12-11 14:28:10 UTC) #1
csharp
lgtm
11 years, 7 months ago (2013-12-11 14:33:57 UTC) #2
M-A
11 years, 7 months ago (2013-12-11 14:36:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9cc42c3 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b