Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 3898044: Add field move_line into account tax line view for trace back. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by udono
Modified:
15 years, 1 month ago
Reviewers:
yangoon, ced
Visibility:
Public.

Description

Patch attached to https://bugs.tryton.org/roundup/issue1813

Patch Set 1 #

Total comments: 2

Patch Set 2 : Put new field on top with colspan other fields. #

Total comments: 1

Patch Set 3 : use select="2" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tax.xml View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
ced
http://codereview.appspot.com/3898044/diff/1/tax.xml File tax.xml (right): http://codereview.appspot.com/3898044/diff/1/tax.xml#newcode586 tax.xml:586: <label name="move_line"/> Isn't it better to put it on ...
15 years, 1 month ago (2011-01-10 08:14:42 UTC) #1
udono
http://codereview.appspot.com/3898044/diff/1/tax.xml File tax.xml (right): http://codereview.appspot.com/3898044/diff/1/tax.xml#newcode586 tax.xml:586: <label name="move_line"/> On 2011/01/10 08:14:43, ced wrote: > Isn't ...
15 years, 1 month ago (2011-01-10 08:31:48 UTC) #2
yangoon
15 years, 1 month ago (2011-01-10 11:26:36 UTC) #3
ced
http://codereview.appspot.com/3898044/diff/4001/tax.xml File tax.xml (right): http://codereview.appspot.com/3898044/diff/4001/tax.xml#newcode601 tax.xml:601: <field name="move_line" select="1"/> We try to have only 3 ...
15 years, 1 month ago (2011-01-10 13:21:48 UTC) #4
udono
On 2011/01/10 13:21:48, ced wrote: > http://codereview.appspot.com/3898044/diff/4001/tax.xml > File tax.xml (right): > > http://codereview.appspot.com/3898044/diff/4001/tax.xml#newcode601 > ...
15 years, 1 month ago (2011-01-10 16:01:27 UTC) #5
ced
15 years, 1 month ago (2011-01-10 16:21:38 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b