Issue 3894041: Domain inversion patch

Issue 3894041: Domain inversion patch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by nicoe

Modified:
15 years ago

Reviewers:
yangoon, ced, udono

Visibility:
Public.

Patch Set 2 : Update to trunk version #

Total comments: 18

Patch Set 3 : Add domain inversion using domain_get computation #

Total comments: 3

Patch Set 4 : Domain inversion patch #

Patch Set 5 : Do a more clever field validation #

Patch Set 6 : Fixed child_of handling #

Total comments: 3

Patch Set 7 : Fixe for cedric's comment #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+556 lines, -123 lines)			Patch
M	CHANGELOG	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	tryton/common/__init__.py	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tryton/common/domain_inversion.py	View	1 2 3 4 5 6	1 chunk	+403 lines, -0 lines	0 comments	Download
A	tryton/common/environment.py	View		1 chunk	+38 lines, -0 lines	0 comments	Download
M	tryton/gui/window/view_form/model/field.py	View	1 2 3 4 5	17 chunks	+86 lines, -12 lines	0 comments	Download
M	tryton/gui/window/view_form/model/group.py	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	tryton/gui/window/view_form/model/record.py	View	1 2 3 4	5 chunks	+10 lines, -60 lines	0 comments	Download
M	tryton/gui/window/view_form/screen/screen.py	View	1 2 3 4 5 6	7 chunks	+8 lines, -46 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/many2one.py	View	1 2 3 4 5 6	1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 25

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/3894041/diff/4001/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): http://codereview.appspot.com/3894041/diff/4001/tryton/common/domain_inversion.py#newcode19 tryton/common/domain_inversion.py:19: IGNORED_OPERATORS = { Not used. Could be merge in ...

15 years, 1 month ago (2011-01-07 17:20:35 UTC) #6

ced

http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py#newcode303 tryton/gui/window/view_form/model/record.py:303: widfield.set_default(self, inverted_domain[0][2], The field should also become readonly

15 years, 1 month ago (2011-01-08 15:10:19 UTC) #7

nicoe

http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/view/form_gtk/many2one.py File tryton/gui/window/view_form/view/form_gtk/many2one.py (left): http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/view/form_gtk/many2one.py#oldcode30 tryton/gui/window/view_form/view/form_gtk/many2one.py:30: self.widget.connect('focus-out-event', lambda x, y: self._focus_out()) On 2011/01/07 17:20:35, ced ...

15 years, 1 month ago (2011-01-10 16:57:16 UTC) #8

ced

15 years, 1 month ago (2011-01-10 17:00:32 UTC) #9

nicoe

http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py#newcode302 tryton/gui/window/view_form/model/record.py:302: and '.' not in inverted_domain[0][0]): On 2011/01/07 17:20:35, ced ...

15 years, 1 month ago (2011-01-10 17:08:30 UTC) #10

ced

http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): http://codereview.appspot.com/3894041/diff/4001/tryton/gui/window/view_form/model/record.py#newcode302 tryton/gui/window/view_form/model/record.py:302: and '.' not in inverted_domain[0][0]): On 2011/01/10 17:08:30, nicoe ...

15 years, 1 month ago (2011-01-10 17:12:25 UTC) #11

nicoe

http://codereview.appspot.com/3894041/diff/4001/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): http://codereview.appspot.com/3894041/diff/4001/tryton/common/domain_inversion.py#newcode36 tryton/common/domain_inversion.py:36: and isinstance(expression[1], basestring) On 2011/01/07 17:20:35, ced wrote: > ...

15 years, 1 month ago (2011-01-10 17:15:46 UTC) #12

ced

http://codereview.appspot.com/3894041/diff/15002/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): http://codereview.appspot.com/3894041/diff/15002/tryton/common/domain_inversion.py#newcode32 tryton/common/domain_inversion.py:32: and len(expression) in (3, 4) In the current design ...

15 years, 1 month ago (2011-01-10 17:32:20 UTC) #14

nicoe

15 years, 1 month ago (2011-01-10 17:51:00 UTC) #15

udono

The patch applies. But I can not see any difference in the client. Do you ...

15 years, 1 month ago (2011-01-13 14:42:53 UTC) #18

udono

I check to create a project with module project, on save the following error raise: ...

15 years, 1 month ago (2011-01-13 14:45:55 UTC) #19

I check to create a project with module project, on save the following error
raise:

Traceback (most recent call last):
  File "/trytond/protocols/netrpc.py", line 48, in run
    res = dispatch(host, port, 'NetRPC', *msg)
  File "/trytond/protocols/dispatcher.py", line 137, in dispatch
    res = getattr(obj, method)(*args, **kargs)
  File "/trytond/model/modelsql.py", line 397, in create
    self._columns[field].set([id_new], self, field, values[field])
  File "/trytond/model/fields/function.py", line 108, in set
    getattr(model, self.setter)(ids, name, value)
  File "/trytond/modules/project/work.py", line 139, in set_parent
    child_timesheet_work_ids = [x.work.id for x in child_project_works]
  File "/trytond/model/browse.py", line 171, in __getattr__
    return self[name]
  File "/trytond/model/browse.py", line 123, in __getitem__
    datas = self._model.read(ids, ffields.keys())
  File "/trytond/model/modelsql.py", line 620, in read
    res2 = self._columns[field].get(ids, self, field_list, values=res)
  File "/trytond/model/fields/function.py", line 89, in get
    res[name] = getattr(model, self.getter)(ids, name)
  File "/trytond/modules/project/work.py", line 113, in get_parent
    if project_work.work.parent.id in ptw2pw:
  File "/trytond/model/browse.py", line 171, in __getattr__
    return self[name]
  File "/trytond/model/browse.py", line 123, in __getitem__
    datas = self._model.read(ids, ffields.keys())
  File "/trytond/model/modelsql.py", line 620, in read
    res2 = self._columns[field].get(ids, self, field_list, values=res)
  File "/trytond/model/fields/function.py", line 89, in get
    res[name] = getattr(model, self.getter)(ids, name)
  File "/trytond/modules/project/work.py", line 113, in 
get_parent

...

    project_works = self.browse(ids)
  File "/trytond/model/modelstorage.py", line 507, in browse
    for x in ids))
  File "/trytond/model/browse.py", line 15, in __init__
    super(BrowseRecordList, self).__init__(lst)
  File "/trytond/model/modelstorage.py", line 507, in <genexpr>
    for x in ids))
RuntimeError: maximum recursion depth exceeded while calling a Python object

nicoe

On 2011/01/13 14:42:53, udono wrote: > The patch applies. But I can not see any ...

15 years, 1 month ago (2011-01-13 15:38:47 UTC) #21

udono

On 2011/01/13 15:38:47, nicoe wrote: > On 2011/01/13 14:42:53, udono wrote: > > The patch ...

15 years, 1 month ago (2011-01-13 19:07:34 UTC) #22

ced

http://codereview.appspot.com/3894041/diff/51001/tryton/common/domain_inversion.py File tryton/common/domain_inversion.py (right): http://codereview.appspot.com/3894041/diff/51001/tryton/common/domain_inversion.py#newcode16 tryton/common/domain_inversion.py:16: 'like': lambda a, b: True, A comment here to ...

15 years, 1 month ago (2011-01-14 11:27:29 UTC) #23

LGTM
Can be committed

Expand All Messages | Collapse All Messages