Issue 3869041: Use with statement to close file object

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3869041: Use with statement to close file object (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ced

Modified:
15 years, 1 month ago

Reviewers:
bch, Ian Wilson, yangoon, nicoe, udono

Visibility:
Public.

Patch Set 2 : Fix space for vengfulsquirrel #

Total comments: 1

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -80 lines)			Patch
M	trytond/backend/mysql/database.py	View		3 chunks	+9 lines, -8 lines	0 comments	Download
M	trytond/backend/postgresql/database.py	View		3 chunks	+9 lines, -6 lines	0 comments	Download
M	trytond/backend/sqlite/database.py	View		4 chunks	+11 lines, -11 lines	0 comments	Download
M	trytond/config.py	View		1 chunk	+5 lines, -1 line	1 comment	Download
M	trytond/ir/action.py	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	trytond/ir/attachment.py	View		4 chunks	+10 lines, -15 lines	0 comments	Download
M	trytond/ir/gen_time_locale.py	View	1	2 chunks	+12 lines, -12 lines	0 comments	Download
M	trytond/ir/module/module.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	trytond/ir/translation.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	trytond/modules/__init__.py	View		3 chunks	+9 lines, -13 lines	0 comments	Download
M	trytond/server.py	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ian Wilson

1 minor thing http://codereview.appspot.com/3869041/diff/1/trytond/ir/gen_time_locale.py File trytond/ir/gen_time_locale.py (right): http://codereview.appspot.com/3869041/diff/1/trytond/ir/gen_time_locale.py#newcode187 trytond/ir/gen_time_locale.py:187: #thi s repository contains the full ...

15 years, 1 month ago (2011-01-05 19:50:54 UTC) #3

yangoon

15 years, 1 month ago (2011-01-07 12:07:17 UTC) #5

http://codereview.appspot.com/3869041/diff/6001/trytond/config.py
File trytond/config.py (right):

http://codereview.appspot.com/3869041/diff/6001/trytond/config.py#newcode137
trytond/config.py:137: fp = open(self.configfile)
not related to 'Use with statement to close file object'

-> perhaps better changeset comment: 'Handle closing of file objects.'

Expand All Messages | Collapse All Messages