Issue 3867043: Add model field access

Issue 3867043: Add model field access (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ced

Modified:
15 years ago

Reviewers:
bch, yangoon, Okko H, nicoe, udono

Visibility:
Public.

Patch Set 2 : Add field access on group for @Okko #

Total comments: 4

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1085 lines, -32 lines)			Patch
M	CHANGELOG	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	trytond/ir/model.py	View		2 chunks	+140 lines, -23 lines	4 comments	Download
M	trytond/ir/model.xml	View		1 chunk	+57 lines, -0 lines	0 comments	Download
M	trytond/model/browse.py	View		1 chunk	+15 lines, -2 lines	0 comments	Download
M	trytond/model/model.py	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	trytond/model/modelstorage.py	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	trytond/model/modelview.py	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	trytond/res/group.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trytond/res/group.xml	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
M	trytond/test/__init__.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	trytond/test/access.py	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	trytond/tests/test_access.py	View		1 chunk	+794 lines, -0 lines	0 comments	Download
M	trytond/tests/test_tryton.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Okko H

Please add the field access to the groups view under access permission, like access models.

15 years, 1 month ago (2011-01-11 11:44:42 UTC) #2

udono

On a first view it works good for me. I tried to simulate my topic ...

15 years, 1 month ago (2011-01-13 16:09:20 UTC) #5

nicoe

http://codereview.appspot.com/3867043/diff/5001/trytond/ir/model.py File trytond/ir/model.py (right): http://codereview.appspot.com/3867043/diff/5001/trytond/ir/model.py#newcode400 trytond/ir/model.py:400: except Exception: Won't you be too aggressive in catching ...

15 years, 1 month ago (2011-01-13 16:22:03 UTC) #6

ced

15 years, 1 month ago (2011-01-14 10:14:13 UTC) #7

http://codereview.appspot.com/3867043/diff/5001/trytond/ir/model.py
File trytond/ir/model.py (right):

http://codereview.appspot.com/3867043/diff/5001/trytond/ir/model.py#newcode400
trytond/ir/model.py:400: except Exception:
On 2011/01/13 16:22:04, nicoe wrote:
> Won't you be too aggressive in catching exceptions

I keep the current way but I filled an issue to improve this:
https://bugs.tryton.org/roundup/issue1825

Expand All Messages | Collapse All Messages