Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 38630043: remove tests for undefined paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by rafaelw
Modified:
11 years, 4 months ago
Reviewers:
arv, John Messerly
Base URL:
https://github.com/Polymer/observe-js.git@master
Visibility:
Public.

Description

remove tests for undefined paths R=arv BUG= Committed: https://github.com/Polymer/observe-js/commit/48e9efe

Patch Set 1 #

Patch Set 2 : ws #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/observe.js View 3 chunks +3 lines, -5 lines 0 comments Download
M tests/test.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rafaelw
This was a omission when we moved to invalidPath. It's no longer possible for Path.get/getPath ...
11 years, 4 months ago (2013-12-06 22:49:54 UTC) #1
rafaelw
Committed patchset #2 manually as r48e9efe (presubmit successful).
11 years, 4 months ago (2013-12-06 22:51:11 UTC) #2
John Messerly
nice cleanup. lgtm
11 years, 4 months ago (2013-12-06 23:11:00 UTC) #3
arv
11 years, 4 months ago (2013-12-09 15:09:51 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b