Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(429)

Issue 38500044: Reading from character special device file in loop.connect_read_pipe does not work. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by jonathan.slenders
Modified:
12 years ago
Reviewers:
Visibility:
Public.

Description

loop.connect_read_pipe does not yet support the pipes that openpty() creates. (Which are apparently character special device files.) The following should work: master, slave = os.openpty() shell_out = io.open(master, 'rb', 0) transport, protocol = yield from loop.connect_read_pipe(MyProtocol, shell_out) In unix_events.py, there's the following check that fails. if not (stat.S_ISFIFO(mode) or stat.S_ISSOCK(mode)): It should probably be replaced with something like this: if not (stat.S_ISFIFO(mode) or stat.S_ISSOCK(mode) or stat.S_ISCHR(mode)): (The attached test does not yet succeed. I'm not sure about it.)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M asyncio/unix_events.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_events.py View 1 chunk +39 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b