Issue 384041: code review 384041: 1. decommit complex(float) conversion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 384041: code review 384041: 1. decommit complex(float) conversion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by ken3

Modified:
15 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

1. decommit complex(float) conversion 2. add complex algorithm for map/chan 3. test for use of complex in array, slice, field, chan, map, field, pointer.

Patch Set 1 #

Patch Set 2 : code review 384041: 1. decommit complex(float) conversion #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -24 lines)			Patch
M	src/cmd/gc/const.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/gc/cplx.c	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	test/ken/cplx3.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/ken/cplx4.go	View	1 chunk	+1 line, -3 lines	0 comments	Download
A	test/ken/cplx5.go	View	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-10 01:51:27 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=a38c8d2c384c *** 1. decommit complex(float) conversion 2. add complex algorithm for map/chan ...

15 years ago (2010-03-10 01:51:32 UTC) #2

LGTM

386 is not quite working; looking into it.

Expand All Messages | Collapse All Messages