Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 3831041: code review 3831041: testing: fix error message on invalid regexp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by ejsherry
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

testing: fix error message on invalid regexp

Patch Set 1 #

Patch Set 2 : code review 3831041: testing: fix error message on invalid regexp #

Patch Set 3 : code review 3831041: testing: fix error message on invalid regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/testing/benchmark.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/testing/testing.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
ejsherry
Hello golang-dev@googlegroups.com, I'd like you to review this change.
12 years, 1 month ago (2010-12-22 18:44:06 UTC) #1
adg
LGTM On 23 December 2010 05:44, <ejsherry@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > ...
12 years, 1 month ago (2010-12-23 00:40:11 UTC) #2
adg
12 years, 1 month ago (2010-12-23 00:40:18 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=ca4aa31aca04 ***

testing: fix error message on invalid regexp

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/3831041

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b