code review 3831041: testing: fix error message on invalid regexp

testing: fix error message on invalid regexp

[ejsherry, 2010-12-22 18:44:06]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[adg, 2010-12-23 00:40:11]

LGTM

On 23 December 2010 05:44,  <ejsherry@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change.
>
>
> Description:
> testing: fix error message on invalid regexp
>
> Please review this at http://codereview.appspot.com/3831041/
>
> Affected files:
>  M src/pkg/testing/benchmark.go
>  M src/pkg/testing/testing.go
>
>
> Index: src/pkg/testing/benchmark.go
> ===================================================================
> --- a/src/pkg/testing/benchmark.go
> +++ b/src/pkg/testing/benchmark.go
> @@ -175,7 +175,7 @@
>        for _, Benchmark := range benchmarks {
>                matched, err := matchString(*matchBenchmarks, Benchmark.Name)
>                if err != nil {
> -                       println("invalid regexp for -benchmarks:", err)
> +                       println("invalid regexp for -benchmarks:",
> err.String())
>                        os.Exit(1)
>                }
>                if !matched {
> Index: src/pkg/testing/testing.go
> ===================================================================
> --- a/src/pkg/testing/testing.go
> +++ b/src/pkg/testing/testing.go
> @@ -144,7 +144,7 @@
>        for i := 0; i < len(tests); i++ {
>                matched, err := matchString(*match, tests[i].Name)
>                if err != nil {
> -                       println("invalid regexp for -match:", err)
> +                       println("invalid regexp for -match:", err.String())
>                        os.Exit(1)
>                }
>                if !matched {
>
>
>

[adg, 2010-12-23 00:40:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=ca4aa31aca04 ***

testing: fix error message on invalid regexp

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/3831041

Committer: Andrew Gerrand <adg@golang.org>