Reply an error message to sender, if ibus-daemon can not forward method call message successfully.

Reply an error message to sender, if ibus-daemon can not forward method call message successfully.

BUG=none
TEST=manually

[Yusuke Sato, 2010-12-28 01:06:54]

LGTM, but I have one question (see below.)

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode887
bus/dbusimpl.c:887: g_object_unref (message);
How about changing line 887-888 to something like:

g_warning ("Unknown method call: destination=NULL, interface=..., member=...,
path=...", ...);
return message;

so that the GDbus library could automatically return an error reply to unknown
method calls like GetAll in DBus.Properties?

If I remember correctly, the GetAll method call
(http://codereview.appspot.com/3836042/) is sent with NULL destination and
therefore is not handled by bus_dbus_impl_forward_message_idle_cb which you
modified in this CL.

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode1062
bus/dbusimpl.c:1062: "No service name is '%s'.", destination);
nitpick: No -> The ??

[Peng, 2010-12-28 19:28:29]

Update CL

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c
File bus/dbusimpl.c (right):

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode887
bus/dbusimpl.c:887: g_object_unref (message);
On 2010/12/28 01:06:54, Yusuke Sato wrote:
> How about changing line 887-888 to something like:
> 
> g_warning ("Unknown method call: destination=NULL, interface=..., member=...,
> path=...", ...);
> return message;
> 
> so that the GDbus library could automatically return an error reply to unknown
> method calls like GetAll in DBus.Properties?
I think so. I will use this way to handle dest==NULL.
> 
> If I remember correctly, the GetAll method call
> (http://codereview.appspot.com/3836042/) is sent with NULL destination and
> therefore is not handled by bus_dbus_impl_forward_message_idle_cb which you
> modified in this CL.

http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode1062
bus/dbusimpl.c:1062: "No service name is '%s'.", destination);
On 2010/12/28 01:06:54, Yusuke Sato wrote:
> nitpick: No -> The ??

Done.

[Yusuke Sato, 2010-12-28 23:21:57]

LGTM, thanks.

On 2010/12/28 19:28:29, Shawn.P.Huang wrote:
> Update CL
> 
> http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c
> File bus/dbusimpl.c (right):
> 
> http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode887
> bus/dbusimpl.c:887: g_object_unref (message);
> On 2010/12/28 01:06:54, Yusuke Sato wrote:
> > How about changing line 887-888 to something like:
> > 
> > g_warning ("Unknown method call: destination=NULL, interface=...,
member=...,
> > path=...", ...);
> > return message;
> > 
> > so that the GDbus library could automatically return an error reply to
unknown
> > method calls like GetAll in DBus.Properties?
> I think so. I will use this way to handle dest==NULL.
> > 
> > If I remember correctly, the GetAll method call
> > (http://codereview.appspot.com/3836042/) is sent with NULL destination and
> > therefore is not handled by bus_dbus_impl_forward_message_idle_cb which you
> > modified in this CL.
> 
> http://codereview.appspot.com/3825042/diff/1/bus/dbusimpl.c#newcode1062
> bus/dbusimpl.c:1062: "No service name is '%s'.", destination);
> On 2010/12/28 01:06:54, Yusuke Sato wrote:
> > nitpick: No -> The ??
> 
> Done.