Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 3814043: Handle loading attribute on fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by ced
Modified:
15 years, 1 month ago
Reviewers:
bch, nicoe, udono
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Validate only fields from view to take advantage of the lazy loading #

Patch Set 3 : Fix typo for reading rec_name #

Total comments: 1

Patch Set 4 : Use if/else instead of and/or #

Patch Set 5 : Be more lazy on next/previous #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -34 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M tryton/gui/window/view_form/model/record.py View 1 2 3 4 8 chunks +51 lines, -19 lines 0 comments Download
M tryton/gui/window/view_form/screen/screen.py View 1 2 3 4 9 chunks +27 lines, -10 lines 0 comments Download
M tryton/gui/window/view_form/view/interface.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/list.py View 1 2 chunks +5 lines, -1 line 0 comments Download
M tryton/gui/window/view_form/view/list_gtk/editabletree.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tryton/gui/window/win_form.py View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11
ced
15 years, 1 month ago (2010-12-27 14:17:19 UTC) #1
ced
15 years, 1 month ago (2010-12-28 16:19:23 UTC) #2
udono
15 years, 1 month ago (2010-12-28 17:59:27 UTC) #3
udono
My first test result is that everything I have seen is working. But the patch ...
15 years, 1 month ago (2010-12-28 18:46:08 UTC) #4
ced
On 2010/12/28 18:46:08, udono wrote: > My first test result is that everything I have ...
15 years, 1 month ago (2010-12-28 18:49:26 UTC) #5
ced
15 years, 1 month ago (2010-12-28 19:46:31 UTC) #6
ced
On 2010/12/28 18:46:08, udono wrote: > My first test result is that everything I have ...
15 years, 1 month ago (2010-12-28 19:46:56 UTC) #7
udono
Ups, I have forgotten the server patch :-) The issue I described before does no ...
15 years, 1 month ago (2010-12-28 20:47:12 UTC) #8
nicoe_old
http://codereview.appspot.com/3814043/diff/9001/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): http://codereview.appspot.com/3814043/diff/9001/tryton/gui/window/view_form/model/record.py#newcode79 tryton/gui/window/view_form/model/record.py:79: lambda x, y: x == y == 'eager' and ...
15 years, 1 month ago (2011-01-03 10:06:06 UTC) #9
ced
15 years, 1 month ago (2011-01-03 10:48:10 UTC) #10
ced
15 years, 1 month ago (2011-01-03 12:17:08 UTC) #11

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b