Issue 3811041: Fix For SHINDIG-1484

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3811041: Fix For SHINDIG-1484

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rbaxter85

Modified:
11 years, 1 month ago

Reviewers:
dev-remailer

CC:
rjbaxter_us.ibm.com

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

When you extend shindig.BaseIfrGadget in your own container the above code makes it difficult to override serverBase_. https://issues.apache.org/jira/browse/SHINDIG-1484

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
		features/src/main/javascript/features/shindig.container/shindig-container.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages