Do not write empty string to "preload_engines" for safety.

Do not write empty string to "preload_engines" for safety.

Without the change, bus_ibus_impl_set_default_preload_engines() might erase an existing preload_engines config when --timeout option for ibus-daemon is too short for ibus_config_get() to success.

BUG=none
TEST=manually with 'ibus-daemon --timeout=1'

[Peng, 2011-01-05 17:40:04]

LGTM.

http://codereview.appspot.com/3789046/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/3789046/diff/1/bus/ibusimpl.c#newcode529
bus/ibusimpl.c:529: g_variant_unref (value);
You test value != NULL in last if statement.  I think the value may be NULL in
here too. So I think it is better to use

if (value != NULL) {

  if (g_variant_n_children (value) >0) {
  ...
  }
  else {
  ...
  }

}

[Yusuke Sato, 2011-01-06 03:24:09]

http://codereview.appspot.com/3789046/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/3789046/diff/1/bus/ibusimpl.c#newcode529
bus/ibusimpl.c:529: g_variant_unref (value);
oops, thanks fixed. submitting.

On 2011/01/05 17:40:04, Shawn.P.Huang wrote:
> You test value != NULL in last if statement.  I think the value may be NULL in
> here too. So I think it is better to use
> 
> if (value != NULL) {
> 
>   if (g_variant_n_children (value) >0) {
>   ...
>   }
>   else {
>   ...
>   }
> 
> }