Issue 3786046: Boolean fields should not have "required" attribute for issue1760

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3786046: Boolean fields should not have "required" attribute for issue1760 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ced

Modified:
15 years, 1 month ago

Reviewers:
udono, yangoon1

Visibility:
Public.

Patch Set 2 : Udono was right: boolean should not get required to True #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	trytond/model/fields/boolean.py	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
	M	trytond/test/test.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

udono

http://codereview.appspot.com/3786046/diff/1/trytond/model/fields/boolean.py File trytond/model/fields/boolean.py (right): http://codereview.appspot.com/3786046/diff/1/trytond/model/fields/boolean.py#newcode17 trytond/model/fields/boolean.py:17: super(Boolean, self).__init__(string=string, help=help, required=True, remove "required=True" from super call.

15 years, 1 month ago (2010-12-23 19:46:15 UTC) #2

ced

15 years, 1 month ago (2010-12-23 20:35:57 UTC) #3

Expand All Messages | Collapse All Messages