Issue 37820051: state/apiserve: Fix TestLoginSetsLogIdentifier

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 37820051: state/apiserve: Fix TestLoginSetsLogIdentifier (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dimitern

Modified:
10 years, 4 months ago

Reviewers:
mp+198680, jameinel

Visibility:
Public.

Description

state/apiserve: Fix TestLoginSetsLogIdentifier This test is mis-written to expect decimal connection ids, but they are actually hex and it only worked because we didn't have enough connections to trigger the issue, which prevented me from landing https://codereview.appspot.com/40290044/ https://code.launchpad.net/~dimitern/juju-core/221-fix-log-tests/+merge/198680 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/apiserver/login_test.go	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, thanks for fixing

Expand All Messages | Collapse All Messages