Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(800)

Issue 3780045: Add a Resource Mutate Visitor to enforce that a resource is in cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by nikhilmadan23
Modified:
15 years, 1 month ago
Reviewers:
johnfargo, zhoresh, satya3656, dev-remailer, gagan.goku
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Added a cache aware resource mutate visitor that reserves html tag nodes whose uri attributes are either not in cache, or are in cache, but the response in cache is either stale or an error response. This is so that any later visitors do not use these nodes.

Patch Set 1 #

Patch Set 2 : Removing Useless Test #

Patch Set 3 : Removing Useless Test #

Total comments: 2

Patch Set 4 : Addressing Gagan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -0 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java View 1 2 3 1 chunk +149 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java View 1 1 chunk +163 lines, -0 lines 0 comments Download

Messages

Total messages: 7
nikhilmadan23
15 years, 2 months ago (2011-01-05 13:21:49 UTC) #1
nikhilmadan23
Removing Useless Test
15 years, 2 months ago (2011-01-06 11:10:39 UTC) #2
anupama.dutta
LGTM. Please send out on dev@.
15 years, 2 months ago (2011-01-07 04:16:05 UTC) #3
gagan.goku
lgtm http://codereview.appspot.com/3780045/diff/6001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java (right): http://codereview.appspot.com/3780045/diff/6001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java#newcode49 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:49: remove extra newline
15 years, 2 months ago (2011-01-07 08:33:35 UTC) #4
nikhilmadan23
http://codereview.appspot.com/3780045/diff/6001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java (right): http://codereview.appspot.com/3780045/diff/6001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java#newcode49 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:49: On 2011/01/07 08:33:35, gagan.goku wrote: > remove extra newline ...
15 years, 2 months ago (2011-01-07 08:43:28 UTC) #5
satya3656
How about making the prefetching optional, controlled by constructor parameter?
15 years, 2 months ago (2011-01-10 12:14:24 UTC) #6
gagan.goku
15 years, 1 month ago (2011-01-19 11:16:54 UTC) #7
On 2011/01/10 12:14:24, satya3656 wrote:
> How about making the prefetching optional, controlled by constructor
parameter?

Build looks good.
Committed as r1060766.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b