Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(463)

Issue 3778042: Pass cookies through in AccelHandler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by nikhilmadan23
Modified:
15 years, 1 month ago
Reviewers:
johnfargo, zhoresh, dev-remailer, gagan.goku
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Make AccelHandler pass Set-Cookie headers through to the client.

Patch Set 1 #

Patch Set 2 : retrying #

Patch Set 3 : retry2 #

Patch Set 4 : retry #

Patch Set 5 : retry #

Patch Set 6 : added tests #

Patch Set 7 : sorry..resending patch #

Patch Set 8 : changed tests #

Patch Set 9 : Set Set-Headers to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HtmlAccelServletTest.java View 1 2 3 4 5 6 7 8 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5
gagan.goku
lgtm, add a test as well that set-cookie is getting passed in the response
15 years, 2 months ago (2010-12-22 10:48:01 UTC) #1
nikhilmadan23
added tests
15 years, 2 months ago (2010-12-22 11:24:04 UTC) #2
gagan.goku
LGTM
15 years, 2 months ago (2010-12-22 13:08:22 UTC) #3
anupama.dutta
LGTM. Please send out to dev@.
15 years, 2 months ago (2010-12-23 06:34:30 UTC) #4
gagan.goku
15 years, 2 months ago (2011-01-04 14:42:33 UTC) #5
Build looks good. Committed as r1055063.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b