sqlalchemy update with sqlite backend

[kindly, 2010-12-29 23:16:41]

http://codereview.appspot.com/3772048/diff/1/ckan/authz.py
File ckan/authz.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/authz.py#oldcode184
ckan/authz.py:184: 
Not so sure it was wrong before.  Issue is due to the queries below.

[kindly, 2010-12-30 02:44:27]

http://codereview.appspot.com/3772048/diff/1/ckan/controllers/package.py
File ckan/controllers/package.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/controllers/package.py#oldc...
ckan/controllers/package.py:296: c.pkg = pkg = model.Package.get(id)
Solved the error below by this
model.Session().autoflush = False

http://codereview.appspot.com/3772048/diff/1/ckan/controllers/package.py#oldc...
ckan/controllers/package.py:353: c.pkg.groups
solved by adding 

Session().autoflush = False

http://codereview.appspot.com/3772048/diff/1/ckan/lib/alphabet_paginate.py
File ckan/lib/alphabet_paginate.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/lib/alphabet_paginate.py#ol...
ckan/lib/alphabet_paginate.py:78: self.alpha_attribute)
look here as to how to do this properly in 0.6.  In 0.5 you can't.

http://www.sqlalchemy.org/docs/orm/query.html#sqlalchemy.orm.query.Query.colu...

http://codereview.appspot.com/3772048/diff/1/ckan/lib/package_saver.py
File ckan/lib/package_saver.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/lib/package_saver.py#oldcod...
ckan/lib/package_saver.py:107: fs.sync()
Did not need to change any of the above just did

model.Session().autoflush = False

BEFORE fs.sync()

http://codereview.appspot.com/3772048/diff/1/ckan/model/__init__.py
File ckan/model/__init__.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/model/__init__.py#oldcode100
ckan/model/__init__.py:100: connection.execute('drop table "%s"' % table.name)
The point of the patch was to do deletes and not drops. So it should change to.

connection.execute('delete from "%s"' % table.name)

http://codereview.appspot.com/3772048/diff/1/ckan/model/__init__.py#oldcode102
ckan/model/__init__.py:102: #self.add_initial_data()
The self.add_initial_data() should be reinstated.

http://codereview.appspot.com/3772048/diff/1/ckan/model/__init__.py#oldcode134
ckan/model/__init__.py:134: raise
Not working yet for me.

http://codereview.appspot.com/3772048/diff/1/ckan/model/domain_object.py
File ckan/model/domain_object.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/model/domain_object.py#oldc...
ckan/model/domain_object.py:38: from sqlalchemy.orm import class_mapper
importing in time critical code is not great.

http://codereview.appspot.com/3772048/diff/1/ckan/model/domain_object.py#oldc...
ckan/model/domain_object.py:41: if Session.connection().engine.has_table(table):
Inspecting the database for what tables there are in time critical code not
good.

http://codereview.appspot.com/3772048/diff/1/ckan/model/domain_object.py
File ckan/model/domain_object.py (right):

http://codereview.appspot.com/3772048/diff/1/ckan/model/domain_object.py#newc...
ckan/model/domain_object.py:38: obj =
Session.query(self).autoflush(autoflush).filter_by(name=name).first()
This is correct as far as I can see.  I have found no issues with it.

http://codereview.appspot.com/3772048/diff/1/ckan/tests/models/test_resource.py
File ckan/tests/models/test_resource.py (left):

http://codereview.appspot.com/3772048/diff/1/ckan/tests/models/test_resource....
ckan/tests/models/test_resource.py:33: if pkg:
I sorted this out by doing a 
model.Session().autoflush = False.
You will not need to create a revision this way