Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 377041: Fix test_jit_gdb under --enable-shared

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by Collin Winter
Modified:
15 years, 10 months ago
Reviewers:
Jeffrey Yasskin
CC:
unladen-swallow_googlegroups.com
Base URL:
http://unladen-swallow.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Without this, gdb hangs forever, waiting for you to tell it to make the breakpoint pending on a future library load. Normal (ie, without --enable-shared) builds still pass the test.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address jyasskin's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Lib/test/test_jit_gdb.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Collin Winter
PTAL
15 years, 10 months ago (2010-03-10 00:19:36 UTC) #1
Jeffrey Yasskin
http://codereview.appspot.com/377041/diff/1/2 File Lib/test/test_jit_gdb.py (right): http://codereview.appspot.com/377041/diff/1/2#newcode49 Lib/test/test_jit_gdb.py:49: "--eval-command=run", You should be able to use "start" instead ...
15 years, 10 months ago (2010-03-10 00:33:19 UTC) #2
Collin Winter
15 years, 10 months ago (2010-03-10 00:39:12 UTC) #3
Committing, thanks for the quick review.

http://codereview.appspot.com/377041/diff/1/2
File Lib/test/test_jit_gdb.py (right):

http://codereview.appspot.com/377041/diff/1/2#newcode49
Lib/test/test_jit_gdb.py:49: "--eval-command=run",
On 2010/03/10 00:33:19, Jeffrey Yasskin wrote:
> You should be able to use "start" instead of "run" to run to main, at which
> point the shared libraries should be loaded. If that doesn't work, this is
fine.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b