Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1120)

Issue 37650048: juju: use parallel.Try

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rog
Modified:
10 years, 3 months ago
Reviewers:
mp+199169, dimitern
Visibility:
Public.

Description

juju: use parallel.Try We use the new Try functionality to simplify the logic somewhat when connecting to juju. It will come more into its own when we connect to multiple addresses. https://code.launchpad.net/~rogpeppe/juju-core/474-juju-use-parallel-try/+merge/199169 Requires: https://code.launchpad.net/~rogpeppe/juju-core/473-parallel-try/+merge/199099 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: use parallel.Try #

Patch Set 3 : juju: use parallel.Try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -114 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/api.go View 1 2 6 chunks +98 lines, -114 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 4 months ago (2013-12-16 18:16:34 UTC) #1
dimitern
Nice simplification, LGTM.
10 years, 4 months ago (2013-12-17 11:23:47 UTC) #2
rog
10 years, 3 months ago (2014-01-14 14:27:21 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b