code review 3746044: 6l: windows/amd64 port

6l: windows/amd64 port

[vcc, 2010-12-31 05:02:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[rsc, 2011-01-19 18:57:46]

LGTM

please change CL description to

6l: windows/amd64 port

and make changes below and i will check in
]

http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile
File src/cmd/6l/Makefile (right):

http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile#newcode27
src/cmd/6l/Makefile:27: pe.$O\
please sort list

http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c
File src/cmd/ld/data.c (right):

http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c#newcode874
src/cmd/ld/data.c:874: if(HEADTYPE == 10)	// Windows PE
if((thechar == '6' || thechar == '8') && HEADTYPE == 10)

10 might mean something else for 5l, for example.

[vcc, 2011-01-20 11:59:34]

PTAL

http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile
File src/cmd/6l/Makefile (right):

http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile#newcode27
src/cmd/6l/Makefile:27: pe.$O\
On 2011/01/19 18:57:46, rsc wrote:
> please sort list

Done.

http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c
File src/cmd/ld/data.c (right):

http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c#newcode874
src/cmd/ld/data.c:874: if(HEADTYPE == 10)	// Windows PE
On 2011/01/19 18:57:46, rsc wrote:
> if((thechar == '6' || thechar == '8') && HEADTYPE == 10)
> 
> 10 might mean something else for 5l, for example.

Done.

[vcc, 2011-01-20 12:01:11]

On 2011/01/19 18:57:46, rsc wrote:
> LGTM
> 
> please change CL description to
> 
> 6l: windows/amd64 port

Done.

> 
> and make changes below and i will check in
> ]
> 
> http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile
> File src/cmd/6l/Makefile (right):
> 
> http://codereview.appspot.com/3746044/diff/2001/src/cmd/6l/Makefile#newcode27
> src/cmd/6l/Makefile:27: pe.$O\
> please sort list
> 
> http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c
> File src/cmd/ld/data.c (right):
> 
> http://codereview.appspot.com/3746044/diff/2001/src/cmd/ld/data.c#newcode874
> src/cmd/ld/data.c:874: if(HEADTYPE == 10)	// Windows PE
> if((thechar == '6' || thechar == '8') && HEADTYPE == 10)
> 
> 10 might mean something else for 5l, for example.

[rsc, 2011-01-20 13:41:10]

LGTM

[rsc, 2011-01-20 14:21:11]

*** Submitted as http://code.google.com/p/go/source/detail?r=2a6fb5158637 ***

6l: windows/amd64 port

R=rsc
CC=golang-dev
http://codereview.appspot.com/3746044

Committer: Russ Cox <rsc@golang.org>