Issue 3746041: code review 3746041: cgo: handle references to symbols in shared libraries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3746041: code review 3746041: cgo: handle references to symbols in shared libraries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:
niemeyer

CC:
r, golang-dev

Visibility:
Public.

cgo: handle references to symbols in shared libraries Fixes issue 1334.

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
M	misc/cgo/life/c-life.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	misc/cgo/life/life.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	misc/cgo/life/life.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	misc/cgo/stdio/file.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/Make.pkg	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1	5 chunks	+12 lines, -2 lines	0 comments	Download

Total messages: 5

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-12-17 18:41:54 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=8634776b7bf1 *** cgo: handle references to symbols in shared libraries Fixes issue ...

13 years, 6 months ago (2010-12-17 19:37:13 UTC) #3

niemeyer

I can confirm this change fixed the problem, but it seems to have broken the ...

13 years, 6 months ago (2010-12-17 21:11:44 UTC) #4

build should be fixed now, sorry