Issue 3737043: Convert dictionary with numeric keys into str for xmlrpc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3737043: Convert dictionary with numeric keys into str for xmlrpc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by ced

Modified:
15 years, 1 month ago

Reviewers:
Paul J Stevens, yangoon1

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	trytond/protocols/xmlrpc.py	View		2 chunks	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Paul J Stevens

http://codereview.appspot.com/3737043/diff/1/trytond/protocols/xmlrpc.py File trytond/protocols/xmlrpc.py (right): http://codereview.appspot.com/3737043/diff/1/trytond/protocols/xmlrpc.py#newcode41 trytond/protocols/xmlrpc.py:41: k = str(int(k)) won't casting a long to an ...

15 years, 1 month ago (2010-12-23 14:16:45 UTC) #3

ced

15 years, 1 month ago (2010-12-23 14:23:49 UTC) #4

http://codereview.appspot.com/3737043/diff/1/trytond/protocols/xmlrpc.py
File trytond/protocols/xmlrpc.py (right):

http://codereview.appspot.com/3737043/diff/1/trytond/protocols/xmlrpc.py#newc...
trytond/protocols/xmlrpc.py:41: k = str(int(k))
On 2010/12/23 14:16:45, Paul J Stevens wrote:
> won't casting a long to an int cause problems if k is a long > max_int?

It is not an issue and it is done like in that in xmlrpclib (but I must admit
that I don't know why).

Expand All Messages | Collapse All Messages