Issue 3711041: Js errors in concat responses should appear in comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3711041: Js errors in concat responses should appear in comments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by pulkitgoyal2000

Modified:
15 years ago

Reviewers:
johnfargo, dev, dev-remailer

CC:
cool-shindig-committers_googlegroups.com, gagan.goku

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

If ConcatProxyServlet gets an error in fetching one of the JS files, it currently writes the error in the served out file as it is. This error should be included as a comment so that the rest of the concatenated js can still be used.

Patch Set 1 #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java	View		2 chunks	+3 lines, -1 line	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ConcatProxyServletTest.java	View		4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

On 2010/12/16 06:01:27, gagan.goku wrote:
> LGTM.

Expand All Messages | Collapse All Messages