Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 3711041: Js errors in concat responses should appear in comments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by pulkitgoyal2000
Modified:
15 years ago
Reviewers:
johnfargo, dev, dev-remailer
CC:
cool-shindig-committers_googlegroups.com, gagan.goku
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

If ConcatProxyServlet gets an error in fetching one of the JS files, it currently writes the error in the served out file as it is. This error should be included as a comment so that the rest of the concatenated js can still be used.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java View 2 chunks +3 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ConcatProxyServletTest.java View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3
pulkitgoyal2000
15 years, 1 month ago (2010-12-16 05:41:30 UTC) #1
gagan.goku
LGTM.
15 years, 1 month ago (2010-12-16 06:01:27 UTC) #2
johnfargo
15 years, 1 month ago (2010-12-20 22:19:24 UTC) #3
LGTM

On 2010/12/16 06:01:27, gagan.goku wrote:
> LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b