code review 3699041: godoc: support for regular expression full text search

src/cmd/godoc/godoc.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package main
 
 import (
         "bytes"
         "flag"
         "fmt"
@@ skipping 46 matching lines @@
         goroot      = flag.String("goroot", runtime.GOROOT(), "Go root directory")
         testDir     = flag.String("testdir", "", "Go root subdirectory - for testing only (faster startups)")
         path        = flag.String("path", "", "additional package directories (colon-separated)")
         filter      = flag.String("filter", "", "filter file containing permitted package directory paths")
         filterMin   = flag.Int("filter_minutes", 0, "filter file update interval in minutes; disabled if <= 0")
         filterDelay delayTime // actual filter update interval in minutes; usually filterDelay == filterMin, but filterDelay may back off exponentially
 
         // layout control
         tabwidth       = flag.Int("tabwidth", 4, "tab width")
         showTimestamps = flag.Bool("timestamps", true, "show timestamps with directory listings")
-        fulltextIndex  = flag.Bool("fulltext", false, "build full text index for search queries")
-        regexpQueries  = flag.Bool("regexp", false, "interpret queries as regular expressions for full text search")
+        fulltextIndex  = flag.Bool("fulltext", false, "build full text index for regular expression queries")
 
         // file system mapping
         fsMap      Mapping // user-defined mapping
         fsTree     RWValue // *Directory tree of packages, updated with each sync
         pathFilter RWValue // filter used when building fsMap directory trees
         fsModified RWValue // timestamp of last call to invalidateIndex
 
         // http handlers
         fileServer http.Handler // default file server
         cmdHandler httpHandler
@@ skipping 1074 matching lines @@
         // textual matches
         Found    int         // number of textual occurrences found
         Textual  []FileLines // textual matches of Query
         Complete bool        // true if all textual occurrences of Query are reported
 }
 
 
 func lookup(query string) (result SearchResult) {
         result.Query = query
 
-        // if regexp queries are disabled, quote the query string:
-        // it will always compile and look like a regexp literal
-        if !*regexpQueries {
-                query = regexp.QuoteMeta(query)
-        }
-
         // determine identifier lookup string and full text regexp
         lookupStr := ""
         lookupRx, err := regexp.Compile(query)
         if err != nil {
                 result.Alert = "Error in query regular expression: " + err.String()
                 return
         }
         if prefix, complete := lookupRx.LiteralPrefix(); complete {
                 // otherwise we lookup "" (with no result) because
                 // identifier lookup doesn't support regexp search
@@ skipping 120 matching lines @@
                         log.Printf("after  GC: bytes = %d footprint = %d", runtime.MemStats.HeapAlloc, runtime.MemStats.Sys)
                 }
                 var delay int64 = 60 * 1e9 // by default, try every 60s
                 if *testDir != "" {
                         // in test mode, try once a second for fast startup
                         delay = 1 * 1e9
                 }
                 time.Sleep(delay)
         }
 }