Issue 3687041: code review 3687041: fix freebsd build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3687041: code review 3687041: fix freebsd build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:

CC:
iant, r, dho, golang-dev

Visibility:
Public.

fix freebsd build

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -13 lines)			Patch
M	src/cmd/6l/asm.c	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/cmd/6l/obj.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8l/asm.c	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/cmd/8l/obj.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/data.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/ld/go.c	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/cmd/ld/lib.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/deps.bash	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/Makefile	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/freebsd.c	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/freebsd_386.c	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/cgo/freebsd_amd64.c	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3

rsc

Hello iant, r (cc: dho, golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-15 22:11:54 UTC) #1

rsc

14 years, 3 months ago (2010-12-15 22:20:29 UTC) #3

*** Submitted as 779efae92db1 ***

fix freebsd build

R=iant, r
CC=dho, golang-dev
http://codereview.appspot.com/3687041