Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 366041: Fix a number of client side CSS issues. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 3 months ago by MikeSamuel
Modified:
16 years, 3 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Autogenerated regular expressions required too much whitespace around commas and slashes. Added support for CSS3 style backgrounds. Will do borders and others in a follow-up CL. Switches to using a regex class for optimization that can differentiate between character set abbreviations and letters when doing head and tail optimizations. Added common substring pooling to the generated JS. With a bit more work in a follow-up CL, this will let us support rgb and rgba colors client side without blowing up the size of the CSS. Submitted @4030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1350 lines, -367 lines) Patch
M src/com/google/caja/ancillary/servlet/Processor.java View 2 chunks +5 lines, -2 lines 0 comments Download
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 4 chunks +12 lines, -9 lines 0 comments Download
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 10 chunks +367 lines, -313 lines 0 comments Download
A src/com/google/caja/lang/css/JSRE.java View 1 chunk +588 lines, -0 lines 0 comments Download
MM src/com/google/caja/lang/css/css-extensions.json View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/lang/css/css-extensions-defs.json View 2 chunks +116 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/css/CssPropertySignature.java View 2 chunks +14 lines, -3 lines 0 comments Download
M src/com/google/caja/plugin/domita.js View 1 chunk +1 line, -1 line 0 comments Download
A src/com/google/caja/util/Bag.java View 1 chunk +88 lines, -0 lines 0 comments Download
M tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 3 chunks +13 lines, -12 lines 0 comments Download
A tests/com/google/caja/lang/css/JSRETest.java View 1 chunk +97 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/CssValidatorTest.java View 12 chunks +48 lines, -26 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 3 months ago (2010-03-09 22:07:32 UTC) #1
MikeSamuel
ping
16 years, 3 months ago (2010-03-16 00:40:45 UTC) #2
metaweta
16 years, 3 months ago (2010-03-23 19:20:49 UTC) #3
Nice tests.  LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b