Refactor getHeight() calculation

So it can be re-used independent of dynamic-height.

[johnfargo, 2010-12-15 00:47:43]

http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
File
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js
(right):

http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js:202:
}
how about sticking this in its own file and sub-feature, so that users can
include it only (and not getViewportDimensions), or vice versa?

[mhermanto, 2010-12-15 20:54:02]

Update patch

[mhermanto, 2010-12-15 20:54:17]

On 2010/12/15 00:47:43, johnfargo wrote:
>
http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
> File
>
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js
> (right):
> 
>
http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
>
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js:202:
> }
> how about sticking this in its own file and sub-feature, so that users can
> include it only (and not getViewportDimensions), or vice versa?

Sure. Done. PTAL.

[johnfargo, 2010-12-15 22:49:48]

LGTM

On 2010/12/15 20:54:17, mhermanto wrote:
> On 2010/12/15 00:47:43, johnfargo wrote:
> >
>
http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
> > File
> >
>
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js
> > (right):
> > 
> >
>
http://codereview.appspot.com/3651041/diff/1/features/src/main/javascript/fea...
> >
>
features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js:202:
> > }
> > how about sticking this in its own file and sub-feature, so that users can
> > include it only (and not getViewportDimensions), or vice versa?
> 
> Sure. Done. PTAL.

[johnfargo, 2010-12-15 22:49:52]

http://codereview.appspot.com/3651041/diff/12001/features/src/main/javascript...
File features/src/main/javascript/features/dynamic-height/feature.xml (right):

http://codereview.appspot.com/3651041/diff/12001/features/src/main/javascript...
features/src/main/javascript/features/dynamic-height/feature.xml:21:
<dependency>dynamic-height.height</dependency>
nit: add util and globals dependencies. They're duplicative in the chain (which
will be filtered out), but providing this is self-documenting

[mhermanto, 2010-12-15 22:53:47]

Done.

On Wed, Dec 15, 2010 at 2:49 PM, <johnfargo@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/3651041/diff/12001/features/src/main/javascript...
> File features/src/main/javascript/features/dynamic-height/feature.xml
> (right):
>
>
>
http://codereview.appspot.com/3651041/diff/12001/features/src/main/javascript...
> features/src/main/javascript/features/dynamic-height/feature.xml:21:
> <dependency>dynamic-height.height</dependency>
> nit: add util and globals dependencies. They're duplicative in the chain
> (which will be filtered out), but providing this is self-documenting
>
>
> http://codereview.appspot.com/3651041/
>