Issue 3608042: code review 3608042: cgo: do not reset tag generator int between files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3608042: code review 3608042: cgo: do not reset tag generator int between files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

cgo: do not reset tag generator between files Clean up an error message and error exit too. Insert blank line after "DO NOT EDIT" comment to keep it from being a doc comment. Fixes issue 1213. Fixes issue 1222.

Patch Set 1 #

Patch Set 2 : code review 3608042: cgo: do not reset tag generator int between files #

Patch Set 3 : code review 3608042: cgo: do not reset tag generator between files #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -8 lines)			Patch
M	misc/cgo/stdio/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	misc/cgo/stdio/test.go	View		4 chunks	+32 lines, -1 line	0 comments	Download
A	misc/cgo/stdio/test1.go	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/cgo/main.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-13 15:21:48 UTC) #1

LGTM fix the typo in the change description before submitting. in fact, just s/int //

14 years, 3 months ago (2010-12-13 16:00:05 UTC) #2

rsc

On Mon, Dec 13, 2010 at 11:00, <r@golang.org> wrote: > LGTM > > fix the ...

14 years, 3 months ago (2010-12-13 18:19:51 UTC) #3

rsc

14 years, 3 months ago (2010-12-13 18:20:09 UTC) #4

*** Submitted as c3b10fce429a ***

cgo: do not reset tag generator between files

Clean up an error message and error exit too.
Insert blank line after "DO NOT EDIT" comment
to keep it from being a doc comment.

Fixes issue 1213.
Fixes issue 1222.

R=r
CC=golang-dev
http://codereview.appspot.com/3608042

Expand All Messages | Collapse All Messages