Issue 3576041: Make better use of RenderingContext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3576041: Make better use of RenderingContext (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by mhermanto

Modified:
15 years ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

... to declaratively specify operations.

Patch Set 2 : Update patch #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -82 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java	View	1	1 chunk	+36 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java	View	1	29 chunks	+65 lines, -66 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/JsUriManager.java	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/JsUriManagerTest.java	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

johnfargo

nit http://codereview.appspot.com/3576041/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java (right): http://codereview.appspot.com/3576041/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java#newcode64 java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java:64: public static RenderingContext valueOfParam(String param) { to be ...

15 years, 2 months ago (2010-12-10 23:56:14 UTC) #2

mhermanto

On 2010/12/10 23:56:14, johnfargo wrote: > nit > > http://codereview.appspot.com/3576041/diff/7001/java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java > File java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java > (right): ...

15 years, 2 months ago (2010-12-15 01:49:10 UTC) #3

johnfargo

15 years, 2 months ago (2010-12-15 02:23:02 UTC) #5

LGTM

On 2010/12/15 01:49:22, mhermanto wrote:
> Update patch

Expand All Messages | Collapse All Messages