Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 3573043: code review 3573043: runtime: only write to standard error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by rsc
Modified:
15 years, 10 months ago
Reviewers:
niemeyer
CC:
r, golang-dev
Visibility:
Public.

Description

runtime: write only to standard error Will mail a warning to golang-nuts once this is submitted.

Patch Set 1 #

Patch Set 2 : code review 3573043: runtime: only write to standard error #

Patch Set 3 : code review 3573043: runtime: write only to standard error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M src/pkg/runtime/print.c View 9 chunks +18 lines, -18 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/runtime/runtime.c View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 10 months ago (2010-12-13 22:04:37 UTC) #1
r
LGTM
15 years, 10 months ago (2010-12-13 22:18:43 UTC) #2
niemeyer
Would it be worth adding a minor note in the spec about the fact it ...
15 years, 10 months ago (2010-12-13 22:20:28 UTC) #3
rsc
On Mon, Dec 13, 2010 at 17:20, <n13m3y3r@gmail.com> wrote: > Would it be worth adding ...
15 years, 10 months ago (2010-12-14 16:52:34 UTC) #4
rsc
*** Submitted as a65963429cbe *** runtime: write only to standard error Will mail a warning ...
15 years, 10 months ago (2010-12-14 16:52:48 UTC) #5
niemeyer
> that would require defining standard error. "println() will send its output to the standard ...
15 years, 10 months ago (2010-12-14 17:12:13 UTC) #6
rsc
15 years, 10 months ago (2010-12-14 17:19:03 UTC) #7
I'm happy to leave the exact semantics of "print"
up to the implementation.  It doesn't need to be
specified.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b