Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 3527043: Add support for configured gadget rendering context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by mhermanto
Modified:
15 years, 2 months ago
Reviewers:
johnfargo, dev-remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Introduce new RenderingContext.CONFIGURED_GADGET. This context is useful for type=url gadgets. These gadgets don't get gadgets.config.init'ed, but require features like container (c=1) renders output, while still rendered in a gadget context. Typically, such gadgets will consume &libs=lib1:lib2 (passed into the iframe) and translates it to /gadgets/js/lib1:lib2.js. now, &c=2 will be tacked onto the URL.

Patch Set 1 : Update patch #

Patch Set 2 : Update patch #

Total comments: 1

Patch Set 3 : Update patch (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -23 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java View 1 chunk +7 lines, -1 line 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/JsUriManager.java View 1 chunk +4 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/JsUriManagerTest.java View 3 chunks +35 lines, -16 lines 0 comments Download

Messages

Total messages: 8
mhermanto
15 years, 2 months ago (2010-12-09 21:44:04 UTC) #1
johnfargo
Quick svn up please -- JsHandler is out of sync w/ @head. Otherwise looks good.
15 years, 2 months ago (2010-12-10 00:31:48 UTC) #2
johnfargo
As well, I'd recommend changing the JsHandler logic to != GADGET rather than == CONFIGURED ...
15 years, 2 months ago (2010-12-10 00:32:28 UTC) #3
mhermanto
Update patch
15 years, 2 months ago (2010-12-10 00:33:50 UTC) #4
johnfargo
LGTM http://codereview.appspot.com/3527043/diff/12002/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java (right): http://codereview.appspot.com/3527043/diff/12002/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java#newcode88 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:88: || renderContext == RenderingContext.CONFIGURED_GADGET) { nit: != GADGET
15 years, 2 months ago (2010-12-10 00:35:50 UTC) #5
mhermanto
Update patch (again)
15 years, 2 months ago (2010-12-10 00:36:29 UTC) #6
johnfargo
LGTM On Thu, Dec 9, 2010 at 4:36 PM, <mhermanto@gmail.com> wrote: > Update patch (again) ...
15 years, 2 months ago (2010-12-10 00:37:29 UTC) #7
mhermanto
15 years, 2 months ago (2010-12-10 00:37:38 UTC) #8
On Thu, Dec 9, 2010 at 4:35 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
>
>
>
http://codereview.appspot.com/3527043/diff/12002/java/gadgets/src/main/java/o...
> File
>
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java
> (right):
>
>
>
http://codereview.appspot.com/3527043/diff/12002/java/gadgets/src/main/java/o...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsHandler.java:88:
> || renderContext == RenderingContext.CONFIGURED_GADGET) {
> nit: != GADGET
>
> Done.

>
> http://codereview.appspot.com/3527043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b