Issue 3513041: CC: Enable gadget navigation in cajole mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3513041: CC: Enable gadget navigation in cajole mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by mhermanto

Modified:
15 years, 2 months ago

Reviewers:
dev-remailer, Jasvir

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 : Update patch #

Total comments: 1

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+100 lines, -2 lines)			Patch
features/src/main/javascript/features/container/constant.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
features/src/main/javascript/features/container/container.js	View	4 chunks	+19 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/container/gadget_holder.js	View	2 chunks	+8 lines, -2 lines	1 comment	Download
features/src/test/javascript/features/container/container_test.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download
features/src/test/javascript/features/container/gadget_holder_test.js	View	2 chunks	+70 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/3513041/diff/4001/features/src/main/javascript/features/container/gadget_holder.js File features/src/main/javascript/features/container/gadget_holder.js (right): http://codereview.appspot.com/3513041/diff/4001/features/src/main/javascript/features/container/gadget_holder.js#newcode208 features/src/main/javascript/features/container/gadget_holder.js:208: // gadgets.rpc.setupReceiver(this.iframeId_, relayUri.toString(), Cruft

15 years, 2 months ago (2010-12-09 00:55:26 UTC) #2

mhermanto

15 years, 2 months ago (2010-12-09 01:11:14 UTC) #3

On Wed, Dec 8, 2010 at 4:55 PM, <jasvir@gmail.com> wrote:

> LGTM
>
>
>
>
http://codereview.appspot.com/3513041/diff/4001/features/src/main/javascript/...
> File features/src/main/javascript/features/container/gadget_holder.js
> (right):
>
>
>
http://codereview.appspot.com/3513041/diff/4001/features/src/main/javascript/...
> features/src/main/javascript/features/container/gadget_holder.js:208: //
>  gadgets.rpc.setupReceiver(this.iframeId_, relayUri.toString(),
> Cruft
>
> Fixed. Good catch.

>
> http://codereview.appspot.com/3513041/
>

Expand All Messages | Collapse All Messages