Issue 3488041: code review 3488041: godoc: don't call flush if position is not valid

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3488041: code review 3488041: godoc: don't call flush if position is not valid (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by gri

Modified:
14 years, 3 months ago

Reviewers:
r

CC:
rsc, iant, golang-dev

Visibility:
Public.

godoc: don't call flush if position is not valid (fixes new godoc crash when looking at spec)

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/godoc/spec.go	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5

gri

Hello rsc, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-06 22:46:06 UTC) #1

gri

Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-12-06 22:46:16 UTC) #2

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=c4ebdd475fdb *** godoc: don't call flush if position is not valid (fixes ...

14 years, 3 months ago (2010-12-06 23:34:26 UTC) #4

LGTM