Issue 3485044: code review 3485044: CONTRIBUTORS: add alias chressie@googlemail.com == chre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3485044: code review 3485044: CONTRIBUTORS: add alias chressie@googlemail.com == chre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:
iant2

CC:
r, golang-dev

Visibility:
Public.

Description

CONTRIBUTORS: add alias chressie@googlemail.com == chressie@gmail.com

Patch Set 1 #

Patch Set 2 : code review 3485044: CONTRIBUTORS: add alias chressie@googlemail.com == chre... #

Patch Set 3 : code review 3485044: CONTRIBUTORS: add alias chressie@googlemail.com == chre... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	CONTRIBUTORS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-07 21:03:59 UTC) #1

rsc

*** Submitted as b860e74bb2f7 *** CONTRIBUTORS: add alias chressie@googlemail.com == chressie@gmail.com R=r CC=golang-dev http://codereview.appspot.com/3485044

14 years, 3 months ago (2010-12-07 21:14:50 UTC) #3

iant2

14 years, 3 months ago (2010-12-07 21:38:16 UTC) #4

LGTM

rsc@golang.org writes:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> CONTRIBUTORS: add alias chressie@googlemail.com == chressie@gmail.com
>
> Please review this at http://codereview.appspot.com/3485044/
>
> Affected files:
>   M CONTRIBUTORS
>
>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -60,7 +60,7 @@
>  Charles L. Dorian <cldorian@gmail.com>
>  Chris Jones <chris@cjones.org> <chris.jones.yar@gmail.com>
>  Chris Lennert <calennert@gmail.com>
> -Christian Himpel <chressie@googlemail.com>
> +Christian Himpel <chressie@googlemail.com> <chressie@gmail.com>
>  Christopher Wedgwood <cw@f00f.org>
>  Conrad Meyer <cemeyer@cs.washington.edu>
>  Corey Thomasson <cthom.lists@gmail.com>

Expand All Messages | Collapse All Messages