Issue 3484042: Add extension params support for ProxyUriBase

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3484042: Add extension params support for ProxyUriBase

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by zhoresh

Modified:
15 years, 2 months ago

Reviewers:
johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk

Visibility:
Public.

Description

The goal is to support implementation specific url parameters by the GadgetHandler. The extension parameters are added to the ProxyUriBase, and added used by ProxyUriManager and JsUriManager when creating the url. The GadgetHandlerService expose the Uri creation function so it can be overloaded to add the extension params.

Patch Set 1 #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+60 lines, -16 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java	View	3 chunks	+14 lines, -11 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/ProxyUriBase.java	View	5 chunks	+18 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java	View	6 chunks	+22 lines, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManagerTest.java	View	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

LGTM It would be best if we as a community somehow stay aware of how ...

15 years, 2 months ago (2010-12-07 19:58:27 UTC) #2

zhoresh

Thanks for the review, committed to r1043198 Agree about being in sync about usage. I ...

15 years, 2 months ago (2010-12-07 21:03:56 UTC) #3

johnfargo

15 years, 2 months ago (2010-12-08 01:14:45 UTC) #4

Yeah, there's no fantastic place for stuff like this, since there's no
programmatic way to monitor use of the function. It's more of a best
practices thing.

On Tue, Dec 7, 2010 at 1:03 PM, Ziv Horesh <zhoresh@gmail.com> wrote:

> Thanks for the review, committed to r1043198
>
> Agree about being in sync about usage. I am not really familiar with the
> document side of shindig to know where to put it.
> In Google we are using it currently for dflags overrides. Dflags is a
> dynamic configuration mechanism.
>
>
>
> On Tue, Dec 7, 2010 at 11:58 AM, <johnfargo@gmail.com> wrote:
>
>> LGTM
>>
>> It would be best if we as a community somehow stay aware of how these
>> params are used, so that common ideas can trickle down into structured
>> fields. Without doing so, we run the risk of duplicating effort we could
>> all utilize.
>>
>>
>> http://codereview.appspot.com/3484042/
>>
>
>

Expand All Messages | Collapse All Messages