Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(157)

Issue 3483041: code review 3483041: use the new %U format for runes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by r
Modified:
14 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

use the new %U format for runes

Patch Set 1 #

Patch Set 2 : code review 3483041: use the new %U format for runes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/cmd/goyacc/goyacc.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bytes/buffer_test.go View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/unicode/maketables.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/utf8/string_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/utf8/utf8_test.go View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 3 months ago (2010-12-06 19:30:43 UTC) #1
rsc1
LGTM I wonder if there should be a %#U format that prints one of U+%04x ...
14 years, 3 months ago (2010-12-06 19:34:22 UTC) #2
r
perhaps. it's easy but of course that issue is why the character is printed twice ...
14 years, 3 months ago (2010-12-06 19:38:00 UTC) #3
r
14 years, 3 months ago (2010-12-06 19:38:26 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=6ebf76a8a974 ***

use the new %U format for runes

R=rsc
CC=golang-dev
http://codereview.appspot.com/3483041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b