LGTM I wonder if there should be a %#U format that prints one of U+%04x ...
14 years, 3 months ago
(2010-12-06 19:34:22 UTC)
#2
LGTM
I wonder if there should be a %#U format that prints one of
U+%04x
U+%04x (%c)
depending on whether the argument is printable.
The errors that say (%c) U+%04x now will look bad
if %c is say '\n'.
perhaps. it's easy but of course that issue is why the character is printed twice ...
14 years, 3 months ago
(2010-12-06 19:38:00 UTC)
#3
perhaps. it's easy but of course that issue is why the character is
printed twice in those errors.
On Mon, Dec 6, 2010 at 2:34 PM, <rsc@google.com> wrote:
> LGTM
>
> I wonder if there should be a %#U format that prints one of
>
> U+%04x
> U+%04x (%c)
>
> depending on whether the argument is printable.
> The errors that say (%c) U+%04x now will look bad
> if %c is say '\n'.
>
>
>
> http://codereview.appspot.com/3483041/
>
*** Submitted as http://code.google.com/p/go/source/detail?r=6ebf76a8a974 *** use the new %U format for runes R=rsc CC=golang-dev http://codereview.appspot.com/3483041
14 years, 3 months ago
(2010-12-06 19:38:26 UTC)
#4
Issue 3483041: code review 3483041: use the new %U format for runes
(Closed)
Created 14 years, 3 months ago by r
Modified 14 years, 3 months ago
Reviewers:
Base URL:
Comments: 0