code review 3473041: builder: Allow buildroot to be passed as command-line a...

misc/dashboard/builder/main.go

 package main
 
 import (
         "container/vector"
         "flag"
         "fmt"
         "io/ioutil"
         "log"
         "os"
         "path"
@@ skipping 19 matching lines @@
         codePassword string
 }
 
 type BenchRequest struct {
         builder *Builder
         commit  Commit
         path    string
 }
 
 var (
+        buildroot     = flag.String("buildroot", path.Join(os.TempDir(), "gobuilder"), "Directory under which to build")
         dashboard     = flag.String("dashboard", "godashboard.appspot.com", "Go Dashboard Host")
         runBenchmarks = flag.Bool("bench", false, "Run benchmarks")
         buildRelease  = flag.Bool("release", false, "Build and upload binary release archives")
         buildRevision = flag.String("rev", "", "Build specified revision and exit")
         buildCmd      = flag.String("cmd", "./all.bash", "Build command (specify absolute or relative to go/src/)")
 )
 
 var (
-        buildroot     = path.Join(os.TempDir(), "gobuilder")
-        goroot        = path.Join(buildroot, "goroot")
+        goroot        string
         releaseRegexp = regexp.MustCompile(`^release\.[0-9\-]+`)
         benchRequests vector.Vector
 )
 
 func main() {
         flag.Usage = func() {
                 fmt.Fprintf(os.Stderr, "usage: %s goos-goarch...\n", os.Args[0])
                 flag.PrintDefaults()
                 os.Exit(2)
         }
         flag.Parse()
         if len(flag.Args()) == 0 {
                 flag.Usage()
         }
+        goroot = path.Join(*buildroot, "goroot")
         builders := make([]*Builder, len(flag.Args()))
         for i, builder := range flag.Args() {
                 b, err := NewBuilder(builder)
                 if err != nil {
                         log.Exit(err)
                 }
                 builders[i] = b
         }
-        if err := os.RemoveAll(buildroot); err != nil {
-                log.Exitf("Error removing build root (%s): %s", buildroot, err)
+        if err := os.RemoveAll(*buildroot); err != nil {
+                log.Exitf("Error removing build root (%s): %s", *buildroot, err)
         }
-        if err := os.Mkdir(buildroot, mkdirPerm); err != nil {
-                log.Exitf("Error making build root (%s): %s", buildroot, err)
+        if err := os.Mkdir(*buildroot, mkdirPerm); err != nil {
+                log.Exitf("Error making build root (%s): %s", *buildroot, err)
         }
-        if err := run(nil, buildroot, "hg", "clone", hgUrl, goroot); err != nil {
+        if err := run(nil, *buildroot, "hg", "clone", hgUrl, goroot); err != nil {
                 log.Exit("Error cloning repository:", err)
         }
         // if specified, build revision and return
         if *buildRevision != "" {
                 c, err := getCommit(*buildRevision)
                 if err != nil {
                         log.Exit("Error finding revision: ", err)
                 }
                 for _, b := range builders {
                         if err := b.buildCommit(c); err != nil {
@@ skipping 140 matching lines @@
 func (b *Builder) buildCommit(c Commit) (err os.Error) {
         defer func() {
                 if err != nil {
                         err = fmt.Errorf("%s buildCommit: %d: %s", b.name, c.num, err)
                 }
         }()
 
         log.Println(b.name, "building", c.num)
 
         // create place in which to do work
-        workpath := path.Join(buildroot, b.name+"-"+strconv.Itoa(c.num))
+        workpath := path.Join(*buildroot, b.name+"-"+strconv.Itoa(c.num))
         err = os.Mkdir(workpath, mkdirPerm)
         if err != nil {
                 return
         }
         benchRequested := false
         defer func() {
                 if !benchRequested {
                         os.RemoveAll(workpath)
                 }
         }()
@@ skipping 80 matching lines @@
 
 func isDirectory(name string) bool {
         s, err := os.Stat(name)
         return err == nil && s.IsDirectory()
 }
 
 func isFile(name string) bool {
         s, err := os.Stat(name)
         return err == nil && (s.IsRegular() || s.IsSymlink())
 }